ls: use locale-aware collation for name sort#11841
Draft
sylvestre wants to merge 1 commit intouutils:mainfrom
Draft
ls: use locale-aware collation for name sort#11841sylvestre wants to merge 1 commit intouutils:mainfrom
sylvestre wants to merge 1 commit intouutils:mainfrom
Conversation
GNU ls uses strcoll() so in UTF-8 locales punctuation is reordered (e.g. '.' sorts before '#'), placing '.' and '..' first in `ls -a` output. uutils was always doing a byte-wise compare, diverging from GNU in non-C locales. Wire up uucore's ICU collator for Sort::Name, gated on should_use_locale_collation() so C/POSIX locales keep the existing zero-overhead byte compare path. Fixes uutils#11831
|
GNU testsuite comparison: |
|
Binary size comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU ls uses strcoll() so in UTF-8 locales punctuation is reordered (e.g. '.' sorts before '#'), placing '.' and '..' first in
ls -aoutput. uutils was always doing a byte-wise compare, diverging from GNU in non-C locales.Wire up uucore's ICU collator for Sort::Name, gated on should_use_locale_collation() so C/POSIX locales keep the existing zero-overhead byte compare path.
Fixes #11831